Opened 7 years ago

Closed 7 years ago

#756 closed enhancement (fixed)

Add caution re LVM removal

Reported by: jonathan.senning@… Owned by: skylar
Priority: major Milestone: 3.2.1
Component: Both Version:
Keywords: Cc:
Blocked By: Blocking:
Estimated Hours: 2 Total Hours: 0

Description

While I agree that typically people would liberate BCCD on a computer that will be fully dedicated to BCCD, this is not always the case. I can imagine cases where someone wants to use BCCD and so adds a new hard drive to an existing machine for that purpose. Or, in my case, I was trying to think of a way for each student in my class to be able to have their own instance of BCCD to play with on our LittleFe?, given that it's inherently set up as a single-user OS, so I was trying to liberate it to a USB drive. What caught me unaware was that doing this wiped the LVM information off the hard drive, which I was hoping to leave alone as it was already set up.

I don't know a whole lot about LVM and I can see how it might be difficult to have the liberate process determine exactly what disks to modify and which to leave alone. How about a warning step where the user is told that liberation will (or at least may) modify information on any and all attached drives and must respond to indicate this is okay to proceed.

On 12/12/2012 06:26 AM, Charlie Peck wrote:

On Dec 7, 2012, at 11:07 PM, Skylar Thompson wrote:

We can make a best effort to ensure that LVM only affect the physical device provided by --libdev, although the nature of LVM is that the logical volumes (what the filesystem sees) are abstracted away from the physical devices. This means that a logical volume could span multiple physical devices, so removing a physical volume could impact logical volumes that have extents elsewhere.

If it's useful, I could try to make liberation a bit more intelligent and try not to zorch more than is needed.

Maybe I'm missing something but don't people typically liberate to disk drives that are on machines that don't have other drives with operating systems/data already on them?

If I understand the issue correctly this is unlikely to be problem for most people, but one with huge negative consequences if they do have other LVM drives on the system.

charlie

_ bccd-developers mailing list bccd-developers@… http://bccd.net/cgi-bin/mailman/listinfo/bccd-developers

-- *Jonathan R. Senning* /Professor of Mathematics and Computer Science/ Gordon College, 255 Grapevine Road, Wenham MA 01984-1899 Voice: 978-867-4376, FAX: 978-867-4585 Email: Jonathan.Senning@… <mailto:jonathan.senning@…> Web: http://www.math-cs.gordon.edu/~senning <http://www.math-cs.gordon.edu/%7Esenning>

_ bccd-developers mailing list bccd-developers@… http://bccd.net/cgi-bin/mailman/listinfo/bccd-developers

Change History (15)

comment:1 Changed 7 years ago by skylar

  • Type changed from defect to enhancement

comment:2 Changed 7 years ago by skylar

  • Owner set to skylar
  • Status changed from new to assigned

comment:3 Changed 7 years ago by skylar

In 3914:

adding option to prompt if LVs exist (#756)

comment:4 Changed 7 years ago by skylar

In 3915:

adding option to liberate.pl to prompt if LVs exist (#756)

comment:5 Changed 7 years ago by skylar

In 3916:

merging in liberate caution (#756)

comment:6 Changed 7 years ago by skylar

  • Status changed from assigned to qa

comment:7 Changed 7 years ago by skylar

In 3921:

Removing unneeded size checks (#756)

comment:8 Changed 7 years ago by skylar

In 3923:

removing old sizing calc (#756),new kernel config w/ more hardware sensors (#666), removing old initramfs-tools config (#760), back to async nfs (#761)

comment:9 Changed 7 years ago by amweeden06

  • Milestone set to 3.2.1

comment:10 Changed 7 years ago by skylar

In 3929:

disable debug for bccd-report (#696), fixing duplicated if statement (#756)

comment:11 Changed 7 years ago by skylar

tested and works

comment:12 Changed 7 years ago by skylar

In 3930:

Merging in fixes for #696, #756

comment:13 Changed 7 years ago by skylar

committing off-by-one fix

comment:14 Changed 7 years ago by skylar

In 3934:

off-by-one error in LV calc causes warning to always appear (#756)

comment:15 Changed 7 years ago by mmludin08

  • Resolution set to fixed
  • Status changed from qa to closed
Note: See TracTickets for help on using tickets.