Changeset 5209 in /cluster/svnroot


Ignore:
Timestamp:
Jul 7, 2015 8:46:19 PM (5 years ago)
Author:
skylar
Message:

docs re #915

Location:
bccd-ng/branches/skylar/bccd-3.4.0
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • bccd-ng/branches/skylar/bccd-3.4.0/bin/build_livecd.pl

    r5198 r5209  
    256256
    257257# Prepare meta-directories in build directory
     258# Possible improvement: Can this be turned into a bind mount?
    258259$Bccd->run_test(
    259260    "system",
     
    335336
    336337# FILE REMOVAL
     338# Can we package these files on our own, and override the provided files?
    337339foreach my $file (
    338340    "$BUILDDIR/etc/apt/sources.list",
  • bccd-ng/branches/skylar/bccd-3.4.0/trees/usr/local/lib/site_perl/Bccd.pm

    r5160 r5209  
    8484Readonly my $IS_BCCD_NETWORK_NIC => 0;
    8585
     86# LOGGING FLAGS
    8687my $debug = 0;
    8788my $INFO = 0b1;
     
    9697}
    9798
     99# LOGGING ROUTINES
     100# Possible improvements:
     101#
     102# carp with calling line number, not log_and_foo line number
     103# Consolidate to one function, use croak and eval{ }
     104# Test logging level w/i logging subroutines, not in calling code
    98105sub log_and_cont( $$$$ ) {
    99106    my($self,$code,$func,$msg) = @_;
     
    125132}
    126133
     134# Possible improvements:
     135# Should return, can catch w/ eval { }
    127136sub cmd_num_die( $@ ) {
    128137    my($self,@cmds) = @_;
    129     my $sub = "cmd_num_due";
     138    my $sub = "cmd_num_die";
    130139    $self->enter_sub($sub);
    131140   
     
    148157}
    149158
     159# LVM ROUTINES
    150160sub get_lvminfo( $$ ) {
    151161    my($self,$layer) = @_;
     
    173183        return;
    174184    }
     185    # BUG: Why the two tests of $rc?
    175186    elsif($rc) {
    176187        if($rc) {
     
    401412    ($rc,$pvinfo) = $self->exec_system($cmd);
    402413    if($rc) {
    403         $self->log_and_cont("@{$cmd} failed with $rc, out $pvinfo");
     414        $self->log_and_cont('ERROR',$sub,"@{$cmd} failed with $rc, out $pvinfo");
    404415        return;
    405416    }
     
    438449}
    439450
     451# Possible improvements:
     452# Use File::Slurp instead?
    440453sub snarf_file( $$ ) {
    441454    my($self,$file) = @_;
Note: See TracChangeset for help on using the changeset viewer.